linux-kernel - Re: [PATCH] spi: spi-mux: Fix coverity issue, unchecked return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOiHx==3Qni3Jv70PV8vDM_7OBLqFG7ARBA41N+jUtV-vcu7uw@mail.gmail.com>
Date: Sat, 15 Mar 2025 11:24:28 +0100
From: Jonas Gorski <jonas.gorski@...il.com>
To: Sergio Perez Gonzalez <sperezglz@...il.com>
Cc: broonie@...nel.org, skhan@...uxfoundation.org, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spi-mux: Fix coverity issue, unchecked return value

Hi,

On Sat, Mar 15, 2025 at 6:01 AM Sergio Perez Gonzalez
<sperezglz@...il.com> wrote:
>
> The return value of spi_setup() is not captured within
> spi_mux_select() and it is assumed to be always success.
>
> CID: 1638374
>
> Signed-off-by: Sergio Perez Gonzalez <sperezglz@...il.com>
> ---
>  drivers/spi/spi-mux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-mux.c b/drivers/spi/spi-mux.c
> index c02c4204442f..0f45a88bfbe7 100644
> --- a/drivers/spi/spi-mux.c
> +++ b/drivers/spi/spi-mux.c
> @@ -68,9 +68,9 @@ static int spi_mux_select(struct spi_device *spi)
>
>         priv->current_cs = spi_get_chipselect(spi, 0);
>
> -       spi_setup(priv->spi);
> +       ret = spi_setup(priv->spi);
>
> -       return 0;
> +       return ret;

Maybe just do

return spi_setup(priv->spi);

Best regards,
Jonas