linux-kernel - Re: [PATCH v2] media: dt-bindings: Convert Analog Devices ad5820 to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec820dbf-5a37-4477-a99d-f3fbe338c198@ixit.cz>
Date: Sat, 15 Mar 2025 14:18:40 +0100
From: David Heidelberg <david@...t.cz>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Pavel Machek <pavel@....cz>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: dt-bindings: Convert Analog Devices ad5820 to
 DT schema



On 14/03/2025 21:57, Sakari Ailus wrote:
> Hi David,
> 
> Thanks for converting this to YAML.
> 
> On Fri, Mar 14, 2025 at 08:58:27PM +0100, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> Convert the Analog Devices ad5820 to DT schema format.
>>
>> Add the previously undocumented io-channel-cells property,
>> which can be omitted. If present, it must be set to 0,
>> as the device provides only one channel.
> 
> What's the purpose of this property? The driver doesn't use it nor I think
> it provides any information on the hardware either. The above description
> also appears to be saying it's redundant.

Hello Sakari,

from my understanding, you're right.

I would prefer to drop it, see [1].

Anyway from reading of documentation I understood it may be right to 
have the property empty, but also may be omitted. I saw both approaches 
in the code.

If you choose not liking this redudancy, I push [1] and drop the 
property here.

David



[1] 
https://patchwork.kernel.org/project/linux-omap/patch/20250213203208.93316-1-david@ixit.cz/

-- 
David Heidelberg