linux-kernel - Re: [PATCH v2] wifi: mac80211: check basic rates validity in sta_link_apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1c6d869-d4ed-41d1-97e2-c73f87864bda@wanadoo.fr>
Date: Sat, 15 Mar 2025 16:20:29 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: m.lobanov@...a.ru
Cc: johannes@...solutions.net, linux-kernel@...r.kernel.org,
 linux-wireless@...r.kernel.org, lvc-project@...uxtesting.org,
 shaul.triebitz@...el.com
Subject: Re: [PATCH v2] wifi: mac80211: check basic rates validity in
 sta_link_apply_parameters

Le 15/03/2025 à 14:01, Mikhail Lobanov a écrit :
> When userspace sets supported rates for a new station via
> NL80211_CMD_NEW_STATION, it might send a list that's empty
> or contains only invalid values. Currently, we process these
> values in sta_link_apply_parameters() without checking the result of
> ieee80211_parse_bitrates(), which can lead to an empty rates bitmap.
> 
> A similar issue was addressed for NL80211_CMD_SET_BSS in commit
> ce04abc3fcc6 ("wifi: mac80211: check basic rates validity").
> This patch applies the same approach in sta_link_apply_parameters()
> for NL80211_CMD_NEW_STATION, ensuring there is at least one valid
> rate by inspecting the result of ieee80211_parse_bitrates().
> 
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
> 
> Fixes: b95eb7f0eee4 ("wifi: cfg80211/mac80211: separate link params from station params")
> Signed-off-by: Mikhail Lobanov <m.lobanov-kcSV9N6+iMo@...lic.gmane.org>
> ---
> v2: Fixed the patch subject to provide a complete description.
> 
>   net/mac80211/cfg.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 9351c64608a9..e7c429aef980 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -1909,10 +1909,11 @@ static int sta_link_apply_parameters(struct ieee80211_local *local,
>   
>   	if (params->supported_rates &&
>   	    params->supported_rates_len) {
> -		ieee80211_parse_bitrates(link->conf->chanreq.oper.width,
> +		(!ieee80211_parse_bitrates(link->conf->chanreq.oper.width,

'if" missing?

>   					 sband, params->supported_rates,
>   					 params->supported_rates_len,
> -					 &link_sta->pub->supp_rates[sband->band]);
> +					 &link_sta->pub->supp_rates[sband->band]))
> +		return -EINVAL;
>   	}
>   
>   	if (params->ht_capa)