linux-kernel - Re: [PATCH v13 2/3] soc: sophgo: cv1800: rtcsys: New driver (handling RTC only)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN0PR01MB10393BB0FDD18288E5FB18E92FEDD2@PN0PR01MB10393.INDPRD01.PROD.OUTLOOK.COM>
Date: Sat, 15 Mar 2025 09:11:25 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>,
 Alexander Sverdlin <alexander.sverdlin@...il.com>, sophgo@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-rtc@...r.kernel.org
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Jingbao Qiu <qiujingbao.dlmu@...il.com>, Arnd Bergmann <arnd@...db.de>,
 Yangyu Chen <cyy@...self.name>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 2/3] soc: sophgo: cv1800: rtcsys: New driver (handling
 RTC only)

Hey, Alexander

On 2025/3/14 8:51, Inochi Amaoto wrote:
> On Sun, Mar 09, 2025 at 09:26:24PM +0100, Alexander Sverdlin wrote:
>> Add driver for Sophgo CV1800 series SoC RTC subsystem. The RTC module
>> comprises a 32kHz oscillator, Power-on-Reset (PoR) sub-module, HW state
>> machine to control chip power-on, power-off and reset. Furthermore, the
>> 8051 subsystem is located within RTCSYS including associated SRAM block.
>>
>> This patch only populates RTC sub-device.
>>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
>> ---
>> Changelog:
>> v13:
>> - Moved the driver from MFD into SOC subsystem
>> - Dropped unused "cv1800_rtcsys_rtc_subdev"
>> v12:
>> - new patch
>>
>>   MAINTAINERS                        |  1 +
>>   drivers/soc/Kconfig                |  1 +
>>   drivers/soc/Makefile               |  1 +
>>   drivers/soc/sophgo/Kconfig         | 24 ++++++++++++
>>   drivers/soc/sophgo/Makefile        |  3 ++
>>   drivers/soc/sophgo/cv1800-rtcsys.c | 63 ++++++++++++++++++++++++++++++
>>   6 files changed, 93 insertions(+)
>>   create mode 100644 drivers/soc/sophgo/Kconfig
>>   create mode 100644 drivers/soc/sophgo/Makefile
>>   create mode 100644 drivers/soc/sophgo/cv1800-rtcsys.c
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3eee238c2ea2..ac15e448fffb 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -22354,6 +22354,7 @@ L:	sophgo@...ts.linux.dev
>>   W:	https://github.com/sophgo/linux/wiki
>>   T:	git https://github.com/sophgo/linux.git
>>   S:	Maintained
>> +F:	drivers/soc/sophgo/cv1800-rtcsys.c
> Please change to the drivers/soc/sophgo/.
> We should maintain all files under this.

In addition to what Inochi mentioned, please add the following line:

F:    Documentation/devicetree/bindings/soc/sophgo/

Thanks,

Chen


[......]