[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <174206348097.159805.1044453003821020231.robh@kernel.org>
Date: Sat, 15 Mar 2025 13:31:21 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: J. Neuschäfer <j.ne@...teo.net>
Cc: Naveen N Rao <naveen@...nel.org>,
Madhavan Srinivasan <maddy@...ux.ibm.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org,
Conor Dooley <conor+dt@...nel.org>, Nicholas Piggin <npiggin@...il.com>,
Michael Ellerman <mpe@...erman.id.au>, Crystal Wood <oss@...error.net>,
linuxppc-dev@...ts.ozlabs.org,
Christophe Leroy <christophe.leroy@...roup.eu>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML
On Sat, 15 Mar 2025 18:27:05 +0100, J. Neuschäfer wrote:
> This patch rewrites pmc.txt into YAML format. Descriptive texts are
> expanded or shortened in a few places to better fit today's conventions.
>
> The list of compatible strings (and combinations of them) is based on
> existing device trees in arch/powerpc as well as compatible strings
> already mentioned in the plain-text version of the binding.
>
> One thing I didn't handle are soc-clk@... nodes as seen in
> Documentation/devicetree/bindings/powerpc/fsl/pmc.yaml.
>
> Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> ---
> .../devicetree/bindings/powerpc/fsl/pmc.txt | 63 --------
> .../devicetree/bindings/powerpc/fsl/pmc.yaml | 159 +++++++++++++++++++++
> 2 files changed, 159 insertions(+), 63 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/powerpc/fsl/pmc.example.dtb: /example-0/sata@...00: failed to match any schema with compatible: ['fsl,mpc8377-sata', 'fsl,pq-sata']
Documentation/devicetree/bindings/powerpc/fsl/pmc.example.dtb: /example-0/sata@...00: failed to match any schema with compatible: ['fsl,mpc8377-sata', 'fsl,pq-sata']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250315-fslpmc-yaml-v1-1-10ba354a85c2@posteo.net
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists