linux-kernel - Re: [PATCH v6 10/10] media: thp7312: Use helper for iterating named child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250315184111.GA29719@pendragon.ideasonboard.com>
Date: Sat, 15 Mar 2025 20:41:11 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Paul Elder <paul.elder@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 10/10] media: thp7312: Use helper for iterating named
 child nodes

Hi Matti,

Thank you for the patch.

On Mon, Mar 10, 2025 at 02:57:40PM +0200, Matti Vaittinen wrote:
> Slightly simplify code iterating the child nodes with specific names
> using the new fwnode_for_each_available_named_child_node().
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> Revision history:
> v5 => v6:
>  - New patch
> 
> NOTE: This patch depends on the patch:
> [2/10] "property: Add functions to iterate named child"
> 
> Compile-tested only!
> ---
>  drivers/media/i2c/thp7312.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c
> index 8852c56431fe..104754b2ace2 100644
> --- a/drivers/media/i2c/thp7312.c
> +++ b/drivers/media/i2c/thp7312.c
> @@ -2067,11 +2067,9 @@ static int thp7312_parse_dt(struct thp7312_device *thp7312)
>  		return -EINVAL;
>  	}
>  
> -	fwnode_for_each_available_child_node(sensors, node) {
> -		if (fwnode_name_eq(node, "sensor")) {
> -			if (!thp7312_sensor_parse_dt(thp7312, node))
> -				num_sensors++;
> -		}
> +	fwnode_for_each_available_named_child_node(sensors, node, "sensor") {
> +		if (!thp7312_sensor_parse_dt(thp7312, node))
> +			num_sensors++;
>  	}
>  
>  	fwnode_handle_put(sensors);

-- 
Regards,

Laurent Pinchart