linux-kernel - Re: [PATCH AUTOSEL 6.13 13/17] mptcp: safety check before fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9TaTcOL1ZkccXr7@lappy>
Date: Fri, 14 Mar 2025 21:39:25 -0400
From: Sasha Levin <sashal@...nel.org>
To: Matthieu Baerts <matttbe@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	martineau@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	netdev@...r.kernel.org, mptcp@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 6.13 13/17] mptcp: safety check before fallback

On Mon, Mar 03, 2025 at 06:05:12PM +0100, Matthieu Baerts wrote:
>Hi Sasha,
>
>On 03/03/2025 17:29, Sasha Levin wrote:
>> From: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
>>
>> [ Upstream commit db75a16813aabae3b78c06b1b99f5e314c1f55d3 ]
>>
>> Recently, some fallback have been initiated, while the connection was
>> not supposed to fallback.
>>
>> Add a safety check with a warning to detect when an wrong attempt to
>> fallback is being done. This should help detecting any future issues
>> quicker.
>>
>> Acked-by: Paolo Abeni <pabeni@...hat.com>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
>> Link: https://patch.msgid.link/20250224-net-mptcp-misc-fixes-v1-3-f550f636b435@kernel.org
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>Thank you for backporting this patch, but is it OK to delay it a bit on
>v6.13 and older please?
>
>This patch depends on its parent commit, commit 8668860b0ad3 ("mptcp:
>reset when MPTCP opts are dropped after join"), on kernels >=v5.19, to
>avoid a WARN().

Waited a bit, looks ok to pull in now :)

-- 
Thanks,
Sasha