linux-kernel - Re: [PATCH] PCI: histb: Remove an unneeded NULL test in histb_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250316115726.GA3021602@rocinante>
Date: Sun, 16 Mar 2025 20:57:26 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Shawn Guo <shawn.guo@...aro.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: histb: Remove an unneeded NULL test in
 histb_pcie_remove()

Hello,

> phy_exit() handles NULL as a parameter, so there is no need for an extra
> test.
> This makes the code consistent with the error handling path of the probe.

Thank you for the due diligence here!  Much appreciated.

I squashed this patch against the changes already on the branch.

Thank you!

	Krzysztof