linux-kernel - Re: [PATCH v2] ext4: hash: simplify kzalloc(n * 1, ...) to kzalloc(n, ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1AFB99D7-8C35-4011-8A76-8D5099963C00@dilger.ca>
Date: Sun, 16 Mar 2025 06:54:11 -0600
From: Andreas Dilger <adilger@...ger.ca>
To: Ethan Carter Edwards <ethan@...ancedwards.com>
Cc: Matthew Wilcox <willy@...radead.org>,
 Theodore Ts'o <tytso@....edu>,
 Ext4 Developers List <linux-ext4@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>,
 linux-fsdevel <linux-fsdevel@...r.kernel.org>,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] ext4: hash: simplify kzalloc(n * 1, ...) to kzalloc(n,
 ...)

On Mar 15, 2025, at 11:33 PM, Ethan Carter Edwards <ethan@...ancedwards.com> wrote:
> 
> sizeof(char) evaluates to 1. Remove the churn.
> 
> Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>

Thanks,

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> Changes in v2:
> - change back to kzalloc because sizeof(char) is 1. Nice catch. Thanks.
> - Link to v1: https://lore.kernel.org/r/20250315-ext4-hash-kcalloc-v1-1-a9132cb49276@ethancedwards.com
> ---
> fs/ext4/hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c
> index deabe29da7fbc3d35f674ff861a2f3b579ffdea2..33cd5b6b02d59fb749844fe481022f5f44244bb6 100644
> --- a/fs/ext4/hash.c
> +++ b/fs/ext4/hash.c
> @@ -302,7 +302,7 @@ int ext4fs_dirhash(const struct inode *dir, const char *name, int len,
> 
> 	if (len && IS_CASEFOLDED(dir) &&
> 	   (!IS_ENCRYPTED(dir) || fscrypt_has_encryption_key(dir))) {
> -		buff = kzalloc(sizeof(char) * PATH_MAX, GFP_KERNEL);
> +		buff = kzalloc(PATH_MAX, GFP_KERNEL);
> 		if (!buff)
> 			return -ENOMEM;
> 
> 
> ---
> base-commit: da920b7df701770e006928053672147075587fb2
> change-id: 20250315-ext4-hash-kcalloc-203033977bd9
> 
> Best regards,
> --
> Ethan Carter Edwards <ethan@...ancedwards.com>
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)