linux-kernel - Re: [PATCH v2 1/1] Input: snvs_pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97cc25c3-4538-4f28-a551-309943ba0768@kernel.org>
Date: Sun, 16 Mar 2025 14:03:52 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ian Ray <ian.ray@...ealthcare.com>
Cc: dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, linux-input@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] Input: snvs_pwrkey - support power-off-time-sec

On 14/03/2025 15:47, Ian Ray wrote:
> On Fri, Mar 14, 2025 at 02:31:12PM +0100, Krzysztof Kozlowski wrote:
>> On 14/03/2025 14:24, Ian Ray wrote:
>>> On Fri, Mar 14, 2025 at 01:55:47PM +0100, Krzysztof Kozlowski wrote:
>>>> On 14/03/2025 10:42, Ian Ray wrote:
>>>>>
>>>>>       /* Get SNVS register Page */
>>>>> @@ -148,6 +152,24 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
>>>>>       if (pdata->irq < 0)
>>>>>               return -EINVAL;
>>>>>
>>>>> +     if (!of_property_read_u32(np, "power-off-time-sec", &val)) {
>>>>
>>>> And when you test your DTS against binding what do you see? I suspect
>>>> new warning.
>>>
>>> I checked the build logs (from a clean workarea), plus run-time dmesg,
>>> both with the DTS change -- and without it.  There are no new warnings
>>> (specifically nothing mentioning snvs-pwrkey or dts or power-off-time).
>>>
>>> If an invalid value (such as "42") is chosen then the probe fails with
>>> -EINVAL as expected.
>>>
>>> Is there something else that I should have checked?
>>
>> I don't know what your build logs process has. I meant dtbs_check
>> against the bindings.
> 
> $ dt-validate -s Documentation/devicetree/bindings/input/input.yaml \
>   arch/arm64/boot/dts/freescale/imx8mp-ppdv2.dtb 


input.yaml is not your binding, unless something changed. Did it? Is it
being applied here?

Test all bindings, so your schema will be applied.

<form letter>
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
</form letter>

Best regards,
Krzysztof