[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250316135008.155304-3-sam.winchenbach@framepointer.org>
Date: Sun, 16 Mar 2025 09:50:05 -0400
From: Sam Winchenbach <sam.winchenbach@...mepointer.org>
To: linux-kernel@...r.kernel.org
Cc: lars@...afoo.de,
Michael.Hennerich@...log.com,
antoniu.miclaus@...log.com,
jic23@...nel.org,
robh@...nel.org,
krzk+dt@...nel.org,
conor+dt@...nel.org,
linux-iio@...r.kernel.org,
devicetree@...r.kernel.org,
sam.winchenbach@...mepointer.org,
bpellegrino@...a.org,
Sam Winchenbach <swinchenbach@...a.org>
Subject: [PATCH v7 3/6] iio: filter: admv8818: fix integer overflow
From: Sam Winchenbach <swinchenbach@...a.org>
HZ_PER_MHZ is only unsigned long. This math overflows, leading to
incorrect results.
Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
Signed-off-by: Sam Winchenbach <swinchenbach@...a.org>
---
drivers/iio/filter/admv8818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c
index 3d8740caa145..cd3aff9a2f7b 100644
--- a/drivers/iio/filter/admv8818.c
+++ b/drivers/iio/filter/admv8818.c
@@ -154,7 +154,7 @@ static int __admv8818_hpf_select(struct admv8818_state *st, u64 freq)
}
/* Close HPF frequency gap between 12 and 12.5 GHz */
- if (freq >= 12000 * HZ_PER_MHZ && freq <= 12500 * HZ_PER_MHZ) {
+ if (freq >= 12000ULL * HZ_PER_MHZ && freq < 12500ULL * HZ_PER_MHZ) {
hpf_band = 3;
hpf_step = 15;
}
--
2.48.1
Powered by blists - more mailing lists