linux-kernel - Re: [PATCH v1] pps: generators: tio: fix platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6939b245-3ff9-431e-8acb-68fed13d276d@enneenne.com>
Date: Sun, 16 Mar 2025 16:24:13 +0100
From: Rodolfo Giometti <giometti@...eenne.com>
To: Raag Jadav <raag.jadav@...el.com>, gregkh@...uxfoundation.org,
 andriy.shevchenko@...ux.intel.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pps: generators: tio: fix platform_set_drvdata()

On 15/03/25 14:31, Raag Jadav wrote:
> Set driver_data correctly and fix illegal memory access on driver reload.
> 
> Fixes: c89755d1111f ("pps: generators: Add PPS Generator TIO Driver")
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>

Acked-by: Rodolfo Giometti <giometti@...eenne.com>

> ---
>   drivers/pps/generators/pps_gen_tio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pps/generators/pps_gen_tio.c b/drivers/pps/generators/pps_gen_tio.c
> index 6c46b46c66cd..6e4a383957d9 100644
> --- a/drivers/pps/generators/pps_gen_tio.c
> +++ b/drivers/pps/generators/pps_gen_tio.c
> @@ -230,7 +230,7 @@ static int pps_gen_tio_probe(struct platform_device *pdev)
>   	hrtimer_init(&tio->timer, CLOCK_REALTIME, HRTIMER_MODE_ABS);
>   	tio->timer.function = hrtimer_callback;
>   	spin_lock_init(&tio->lock);
> -	platform_set_drvdata(pdev, &tio);
> +	platform_set_drvdata(pdev, tio);
>   
>   	return 0;
>   }
> 
> base-commit: 6f119e3da79ce5e586340059403ab77201c1bb45

-- 
GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming