[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7e5ff689-c013-47c2-982b-e7f4c1d233ca@kwiboo.se>
Date: Sun, 16 Mar 2025 22:25:53 +0100
From: Jonas Karlman <jonas@...boo.se>
To: Kever Yang <kever.yang@...k-chips.com>
Cc: heiko@...ech.de, linux-rockchip@...ts.infradead.org,
Finley Xiao <finley.xiao@...k-chips.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH v2 3/3] nvmem: rockchip-otp: Add support for rk3562
Hi Kever,
On 2025-02-27 12:08, Kever Yang wrote:
> From: Finley Xiao <finley.xiao@...k-chips.com>
>
> This adds the necessary data for handling otp on the rk3562.
>
> Signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>
> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> ---
>
> Changes in v2: None
>
> drivers/nvmem/rockchip-otp.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
> index a04bce89ecc8..6f86cf8ec390 100644
> --- a/drivers/nvmem/rockchip-otp.c
> +++ b/drivers/nvmem/rockchip-otp.c
> @@ -341,6 +341,17 @@ static const struct rockchip_data px30_data = {
> .reg_read = px30_otp_read,
> };
>
> +static const char * const rk3562_otp_clocks[] = {
> + "usr", "sbpi", "apb_pclk", "phy",
> +};
These are the same clocks as used for rk3568 below.
> +
> +static const struct rockchip_data rk3562_data = {
> + .size = 0x80,
> + .clks = rk3562_otp_clocks,
> + .num_clks = ARRAY_SIZE(rk3562_otp_clocks),
> + .reg_read = rk3568_otp_read,
> +};
> +
> static const char * const rk3568_otp_clocks[] = {
> "usr", "sbpi", "apb_pclk", "phy",
> };
> @@ -372,6 +383,10 @@ static const struct of_device_id rockchip_otp_match[] = {
> .compatible = "rockchip,rk3308-otp",
> .data = &px30_data,
> },
> + {
> + .compatible = "rockchip,rk3562-otp",
> + .data = &rk3562_data,
Here we can use rk3568_data directly without having to add a new
rk3562_data struct.
Regards,
Jonas
> + },
> {
> .compatible = "rockchip,rk3568-otp",
> .data = &rk3568_data,
Powered by blists - more mailing lists