| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250317025922.1526937-5-jacky_chou@aspeedtech.com>
Date: Mon, 17 Mar 2025 10:59:22 +0800
From: Jacky Chou <jacky_chou@...eedtech.com>
To: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <pabeni@...hat.com>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <joel@....id.au>,
<andrew@...econstruct.com.au>, <ratbert@...aday-tech.com>,
<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-aspeed@...ts.ozlabs.org>
CC: <BMC-SW@...eedtech.com>
Subject: [net-next 4/4] net: ftgmac100: add RGMII delay for AST2600
Use rx-internal-delay-ps and tx-internal-delay-ps
properties to configue the RGMII delay into corresponding register of
scu. Currently, the ftgmac100 driver only configures on AST2600 and will
be by pass the other platforms.
The details are in faraday,ftgmac100.yaml.
Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
---
drivers/net/ethernet/faraday/ftgmac100.c | 88 ++++++++++++++++++++++++
drivers/net/ethernet/faraday/ftgmac100.h | 12 ++++
2 files changed, 100 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 17ec35e75a65..ea2061488cba 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -27,6 +27,9 @@
#include <linux/phy_fixed.h>
#include <net/ip.h>
#include <net/ncsi.h>
+#include <linux/mfd/syscon.h>
+#include <linux/regmap.h>
+#include <linux/bitfield.h>
#include "ftgmac100.h"
@@ -1812,6 +1815,88 @@ static bool ftgmac100_has_child_node(struct device_node *np, const char *name)
return ret;
}
+static void ftgmac100_set_internal_delay(struct platform_device *pdev)
+{
+ struct device_node *np = pdev->dev.of_node;
+ struct net_device *netdev;
+ struct ftgmac100 *priv;
+ struct regmap *scu;
+ u32 rgmii_tx_delay, rgmii_rx_delay;
+ u32 dly_reg, tx_dly_mask, rx_dly_mask;
+ int tx, rx;
+
+ netdev = platform_get_drvdata(pdev);
+ priv = netdev_priv(netdev);
+
+ tx = of_property_read_u32(np, "tx-internal-delay-ps", &rgmii_tx_delay);
+ rx = of_property_read_u32(np, "rx-internal-delay-ps", &rgmii_rx_delay);
+
+ if (of_device_is_compatible(np, "aspeed,ast2600-mac")) {
+ /* According to mac base address to get mac index */
+ switch (priv->res->start) {
+ case 0x1e660000:
+ dly_reg = AST2600_MAC12_CLK_DLY;
+ tx_dly_mask = AST2600_MAC1_TX_DLY;
+ rx_dly_mask = AST2600_MAC1_RX_DLY;
+ rgmii_tx_delay = FIELD_PREP(AST2600_MAC1_TX_DLY, rgmii_tx_delay);
+ rgmii_rx_delay = FIELD_PREP(AST2600_MAC1_RX_DLY, rgmii_rx_delay);
+ break;
+ case 0x1e680000:
+ dly_reg = AST2600_MAC12_CLK_DLY;
+ tx_dly_mask = AST2600_MAC2_TX_DLY;
+ rx_dly_mask = AST2600_MAC2_RX_DLY;
+ rgmii_tx_delay = FIELD_PREP(AST2600_MAC2_TX_DLY, rgmii_tx_delay);
+ rgmii_rx_delay = FIELD_PREP(AST2600_MAC2_RX_DLY, rgmii_rx_delay);
+ break;
+ case 0x1e670000:
+ dly_reg = AST2600_MAC34_CLK_DLY;
+ tx_dly_mask = AST2600_MAC3_TX_DLY;
+ rx_dly_mask = AST2600_MAC3_RX_DLY;
+ rgmii_tx_delay = FIELD_PREP(AST2600_MAC3_TX_DLY, rgmii_tx_delay);
+ rgmii_rx_delay = FIELD_PREP(AST2600_MAC3_RX_DLY, rgmii_rx_delay);
+ break;
+ case 0x1e690000:
+ dly_reg = AST2600_MAC34_CLK_DLY;
+ tx_dly_mask = AST2600_MAC4_TX_DLY;
+ rx_dly_mask = AST2600_MAC4_RX_DLY;
+ rgmii_tx_delay = FIELD_PREP(AST2600_MAC4_TX_DLY, rgmii_tx_delay);
+ rgmii_rx_delay = FIELD_PREP(AST2600_MAC4_RX_DLY, rgmii_rx_delay);
+ break;
+ default:
+ dev_warn(&pdev->dev, "Invalid mac base address");
+ return;
+ }
+ } else {
+ return;
+ }
+
+ scu = syscon_regmap_lookup_by_phandle(np, "scu");
+ if (IS_ERR(scu)) {
+ dev_warn(&pdev->dev, "failed to map scu base");
+ return;
+ }
+
+ if (!tx) {
+ /* Use tx-internal-delay-ps as index to configure tx delay
+ * into scu register.
+ */
+ if (rgmii_tx_delay > 64)
+ dev_warn(&pdev->dev, "Get invalid tx delay value");
+ else
+ regmap_update_bits(scu, dly_reg, tx_dly_mask, rgmii_tx_delay);
+ }
+
+ if (!rx) {
+ /* Use rx-internal-delay-ps as index to configure rx delay
+ * into scu register.
+ */
+ if (rgmii_tx_delay > 64)
+ dev_warn(&pdev->dev, "Get invalid rx delay value");
+ else
+ regmap_update_bits(scu, dly_reg, rx_dly_mask, rgmii_rx_delay);
+ }
+}
+
static int ftgmac100_probe(struct platform_device *pdev)
{
struct resource *res;
@@ -1977,6 +2062,9 @@ static int ftgmac100_probe(struct platform_device *pdev)
if (of_device_is_compatible(np, "aspeed,ast2600-mac"))
iowrite32(FTGMAC100_TM_DEFAULT,
priv->base + FTGMAC100_OFFSET_TM);
+
+ /* Configure RGMII delay if there are the corresponding properties */
+ ftgmac100_set_internal_delay(pdev);
}
/* Default ring sizes */
diff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h
index 4968f6f0bdbc..d464d287502c 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.h
+++ b/drivers/net/ethernet/faraday/ftgmac100.h
@@ -271,4 +271,16 @@ struct ftgmac100_rxdes {
#define FTGMAC100_RXDES1_UDP_CHKSUM_ERR (1 << 26)
#define FTGMAC100_RXDES1_IP_CHKSUM_ERR (1 << 27)
+/* Aspeed SCU */
+#define AST2600_MAC12_CLK_DLY 0x340
+#define AST2600_MAC1_TX_DLY GENMASK(5, 0)
+#define AST2600_MAC1_RX_DLY GENMASK(17, 12)
+#define AST2600_MAC2_TX_DLY GENMASK(11, 6)
+#define AST2600_MAC2_RX_DLY GENMASK(23, 18)
+#define AST2600_MAC34_CLK_DLY 0x350
+#define AST2600_MAC3_TX_DLY AST2600_MAC1_TX_DLY
+#define AST2600_MAC3_RX_DLY AST2600_MAC1_RX_DLY
+#define AST2600_MAC4_TX_DLY AST2600_MAC2_TX_DLY
+#define AST2600_MAC4_RX_DLY AST2600_MAC2_RX_DLY
+
#endif /* __FTGMAC100_H */
--
2.34.1
Powered by blists - more mailing lists