linux-kernel - Re: [PATCH v3] pinctrl: spacemit: enable config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317132955-GYC1983@gentoo>
Date: Mon, 17 Mar 2025 13:29:55 +0000
From: Yixun Lan <dlan@...too.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>, Alex Elder <elder@...nel.org>,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, spacemit@...ts.linux.dev,
	Conor Dooley <conor.dooley@...rochip.com>,
	Alex Elder <elder@...cstar.com>
Subject: Re: [PATCH v3] pinctrl: spacemit: enable config option

Hi Geert:

On 13:59 Mon 17 Mar     , Geert Uytterhoeven wrote:
> Hi Yixun,
> 
> On Mon, 17 Mar 2025 at 13:41, Yixun Lan <dlan@...too.org> wrote:
> > On 09:18 Mon 17 Mar     , Geert Uytterhoeven wrote:
> > > Thanks for your patch, which is now commit 7ff4faba63571c51
> > > ("pinctrl: spacemit: enable config option") in v6.14-rc7.
> > >
> > > On Tue, 18 Feb 2025 at 01:32, Yixun Lan <dlan@...too.org> wrote:
> > > > Pinctrl is an essential driver for SpacemiT's SoC,
> > > > The uart driver requires it, same as sd card driver,
> > > > so let's enable it by default for this SoC.
> > > >
> > > > The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
> > > > 'make defconfig' to select kernel configuration options.
> > > > This result in a broken uart driver where fail at probe()
> > > > stage due to no pins found.
> > >
> > > Perhaps this is an issue with the uart driver?
> > > I just disabled CONFIG_PINCTRL_RZA2 on RZA2MEVB (which is one of the
> > > few Renesas platforms where the pin control driver is not enabled by
> > > default, for saving memory), and the system booted fine into a Debian
> > > nfsroot.  Probe order of some devices did change, and "Trying to
> > > probe devices needed for running init" was printed.
> > >
> > my problem was CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled, result as
> > # CONFIG_PINCTRL_SPACEMIT_K1 is not set
> >
> > for your case, is CONFIG_PINCTRL_RZA2 built as module?
> > it should work for uart driver with deferred probe mechanism..
> 
> No, CONFIG_PINCTRL_RZA2 was disabled in my testing.
> 
emm, this is interesting, there might be problem that uart driver
fail to have correct pin settings without pre initialization..

which uart driver is used in RZA2MEVB platform? any pinctrl dts property?
different hardware may vary..

> > > > --- a/drivers/pinctrl/spacemit/Kconfig
> > > > +++ b/drivers/pinctrl/spacemit/Kconfig
> > > > @@ -4,9 +4,10 @@
> > > >  #
> > > >
> > > >  config PINCTRL_SPACEMIT_K1
> > > > -       tristate "SpacemiT K1 SoC Pinctrl driver"
> > > > +       bool "SpacemiT K1 SoC Pinctrl driver"
> > > >         depends on ARCH_SPACEMIT || COMPILE_TEST
> > > >         depends on OF
> > > > +       default y
> > >
> > > Ouch, fix sent...
> > > "[PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to
> > > y unconditionally"
> > > https://lore.kernel.org/6881b8d1ad74ac780af8a974e604b5ef3f5d4aad.1742198691.git.geert+renesas@glider.be
> > >
> > I got suggestion in v1
> > https://lore.kernel.org/all/20250211-nature-kilt-9882e53e5a3f@spud/
> 
> Yeah, I read that, but only after I noticed the issue in v6.14-rc7.
> 
> > so for COMPILE_TEST case, ARCH_SPACEMIT config won't be enabled? then neither PINCTRL_SPACEMIT_K1
> > anyway, I'm fine with either way, thanks
> >
> > > >         select GENERIC_PINCTRL_GROUPS
> > > >         select GENERIC_PINMUX_FUNCTIONS
> > > >         select GENERIC_PINCONF
> 
> It depends. ARCH_SPACEMIT can be enabled only when building for
> RISC-V, while COMPILE_TEST can be enabled everywhere.
> 
Ok, good to know
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55