linux-kernel - Re: [PATCH v3 3/8] perf sched stats: Add schedstat v17 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7ebab9d-536c-4e3d-a916-30f45fb2e5f6@amd.com>
Date: Mon, 17 Mar 2025 19:02:06 +0530
From: "Sapkal, Swapnil" <swapnil.sapkal@....com>
To: Namhyung Kim <namhyung@...nel.org>
CC: <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
	<irogers@...gle.com>, <james.clark@....com>, <ravi.bangoria@....com>,
	<yu.c.chen@...el.com>, <mark.rutland@....com>,
	<alexander.shishkin@...ux.intel.com>, <jolsa@...nel.org>,
	<rostedt@...dmis.org>, <vincent.guittot@...aro.org>,
	<adrian.hunter@...el.com>, <kan.liang@...ux.intel.com>,
	<gautham.shenoy@....com>, <kprateek.nayak@....com>, <juri.lelli@...hat.com>,
	<yangjihong@...edance.com>, <void@...ifault.com>, <tj@...nel.org>,
	<sshegde@...ux.ibm.com>, <linux-kernel@...r.kernel.org>,
	<linux-perf-users@...r.kernel.org>, <santosh.shukla@....com>,
	<ananth.narayan@....com>, <sandipan.das@....com>
Subject: Re: [PATCH v3 3/8] perf sched stats: Add schedstat v17 support

Hello Namhyung,

On 3/15/2025 7:57 AM, Namhyung Kim wrote:
> On Tue, Mar 11, 2025 at 12:02:25PM +0000, Swapnil Sapkal wrote:
>> /proc/schedstat file output is standardized with version number.
>> Add support to record and raw dump v17 version layout.
>>
>> Co-developed-by: Ravi Bangoria <ravi.bangoria@....com>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@....com>
>> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@....com>
>> ---
>>   tools/lib/perf/Makefile                     |  2 +-
>>   tools/lib/perf/include/perf/event.h         | 14 +++++
>>   tools/lib/perf/include/perf/schedstat-v17.h | 61 +++++++++++++++++++++
>>   tools/perf/util/event.c                     |  6 ++
>>   tools/perf/util/synthetic-events.c          | 15 +++++
>>   5 files changed, 97 insertions(+), 1 deletion(-)
>>   create mode 100644 tools/lib/perf/include/perf/schedstat-v17.h
>>
>> diff --git a/tools/lib/perf/Makefile b/tools/lib/perf/Makefile
>> index d0506a13a97f..30712ce8b6b1 100644
>> --- a/tools/lib/perf/Makefile
>> +++ b/tools/lib/perf/Makefile
>> @@ -174,7 +174,7 @@ install_lib: libs
>>   		$(call do_install_mkdir,$(libdir_SQ)); \
>>   		cp -fpR $(LIBPERF_ALL) $(DESTDIR)$(libdir_SQ)
>>   
>> -HDRS := bpf_perf.h core.h cpumap.h threadmap.h evlist.h evsel.h event.h mmap.h schedstat-v15.h schedstat-v16.h
>> +HDRS := bpf_perf.h core.h cpumap.h threadmap.h evlist.h evsel.h event.h mmap.h schedstat-v15.h schedstat-v16.h schedstat-v17.h
> 
> Please put them in a separate line like
> 
> HDRS += schedstat-v15.h schedstat-v16.h schedstat-v17.h
> 

Sure, Will change accordingly.

> Thanks,
> Namhyung
> 

--
Thanks and Regards,
Swapnil