linux-kernel - Re: [PATCH linux-next] sparc/vio: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025031743-cheating-latch-ba8f@gregkh>
Date: Mon, 17 Mar 2025 14:54:45 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: xie.ludan@....com.cn
Cc: andreas@...sler.com, davem@...emloft.net, ukleinek@...nel.org,
	jonathan.cameron@...wei.com, mathieu.poirier@...aro.org,
	quic_zijuhu@...cinc.com, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, xu.xin16@....com.cn,
	yang.yang29@....com.cn
Subject: Re: [PATCH linux-next] sparc/vio: use sysfs_emit() instead of
 scnprintf().

On Mon, Mar 17, 2025 at 04:04:56PM +0800, xie.ludan@....com.cn wrote:
> From: XieLudan <xie.ludan@....com.cn>
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: XieLudan <xie.ludan@....com.cn>
> ---
>  arch/sparc/kernel/vio.c | 2 +-

Do you have this hardware and have tested it?  If not, I wouldn't mess
with existing code, just follow the documentation for new submissions,
leave old stuff alone as it's already working.

thanks,

greg k-h