[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-3-bd924634b889@linaro.org>
Date: Mon, 17 Mar 2025 00:39:35 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>
Cc: Jingjing Xiong <jingjing.xiong@...el.com>, Hao Yao <hao.yao@...el.com>,
Jim Lai <jim.lai@...el.com>, You-Sheng Yang <vicamo.yang@...onical.com>,
Alan Stern <stern@...land.harvard.edu>, Hans de Goede <hdegoede@...hat.com>,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Subject: [PATCH 3/8] media: i2c: ov02e10: Drop IPU6 FPGA specific handshake
GPIO
The IPU6 handshake GPIO signals to the FPGA on IPU6/IPU7 laptops and as
such is not a sensor signal.
Hans has a proposal for handling those GPIOs below. Dropf from the incoming
sensor driver.
link: https://lore.kernel.org/linux-media/4b87a956-a767-48dc-b98b-f80d9a44adc8@redhat.com
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
---
drivers/media/i2c/ov02e10.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/media/i2c/ov02e10.c b/drivers/media/i2c/ov02e10.c
index db27d8c9f3f0b8dd6df6f9757cc674075e419075..29f9eec927b4660f941fa8e32249b321d25b7735 100644
--- a/drivers/media/i2c/ov02e10.c
+++ b/drivers/media/i2c/ov02e10.c
@@ -240,7 +240,6 @@ struct ov02e10 {
struct clk *img_clk;
struct regulator *avdd;
struct gpio_desc *reset;
- struct gpio_desc *handshake;
/* Current mode */
const struct ov02e10_mode *cur_mode;
@@ -533,12 +532,6 @@ static int ov02e10_get_pm_resources(struct device *dev)
return dev_err_probe(dev, PTR_ERR(ov02e10->reset),
"failed to get reset gpio\n");
- ov02e10->handshake = devm_gpiod_get_optional(dev, "handshake",
- GPIOD_OUT_LOW);
- if (IS_ERR(ov02e10->handshake))
- return dev_err_probe(dev, PTR_ERR(ov02e10->handshake),
- "failed to get handshake gpio\n");
-
ov02e10->img_clk = devm_clk_get_optional(dev, NULL);
if (IS_ERR(ov02e10->img_clk))
return dev_err_probe(dev, PTR_ERR(ov02e10->img_clk),
@@ -563,7 +556,6 @@ static int ov02e10_power_off(struct device *dev)
int ret = 0;
gpiod_set_value_cansleep(ov02e10->reset, 1);
- gpiod_set_value_cansleep(ov02e10->handshake, 0);
if (ov02e10->avdd)
ret = regulator_disable(ov02e10->avdd);
@@ -593,14 +585,8 @@ static int ov02e10_power_on(struct device *dev)
return ret;
}
}
- gpiod_set_value_cansleep(ov02e10->handshake, 1);
gpiod_set_value_cansleep(ov02e10->reset, 0);
- /* Lattice MIPI aggregator with some version FW needs longer delay
- after handshake triggered. We set 25ms as a safe value and wait
- for a stable version FW. */
- msleep_interruptible(25);
-
return ret;
}
--
2.48.1
Powered by blists - more mailing lists