linux-kernel - Re: [PATCH] Replace nested max() with single max3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9351765f-685f-4de8-b1e0-695627a29af0@amd.com>
Date: Mon, 17 Mar 2025 14:59:19 +0100
From: Christian König <christian.koenig@....com>
To: feng.wei8@....com.cn, sumit.semwal@...aro.org
Cc: benjamin.gaignard@...labora.com, brian.starkey@....com,
 jstultz@...gle.com, tjmercier@...gle.com, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Replace nested max() with single max3()

Am 15.03.25 um 05:40 schrieb feng.wei8@....com.cn:
> From: FengWei <feng.wei8@....com.cn>
>
> Use max3() macro instead of nesting max() to simplify the return
> statement.

Please add a "dma-buf: heaps: " prefix to the subject line, apart from that looks good to me.

Regards,
Christian.

>
> Signed-off-by: FengWei <feng.wei8@....com.cn>
> ---
>  drivers/dma-buf/dma-heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> index 3cbe87d4a464..96cb9ab5731a 100644
> --- a/drivers/dma-buf/dma-heap.c
> +++ b/drivers/dma-buf/dma-heap.c
> @@ -147,7 +147,7 @@ static long dma_heap_ioctl(struct file *file, unsigned int ucmd,
>  		in_size = 0;
>  	if ((ucmd & kcmd & IOC_OUT) == 0)
>  		out_size = 0;
> -	ksize = max(max(in_size, out_size), drv_size);
> +	ksize = max3(in_size, out_size, drv_size);
>
>  	/* If necessary, allocate buffer for ioctl argument */
>  	if (ksize > sizeof(stack_kdata)) {