linux-kernel - Re: [PATCH] printk/panic: Add option allow non panic cpus logging to ringbuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84senbpwxu.fsf@jogness.linutronix.de>
Date: Mon, 17 Mar 2025 15:19:17 +0106
From: John Ogness <john.ogness@...utronix.de>
To: Petr Mladek <pmladek@...e.com>, Donghyeok Choe <d7271.choe@...sung.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Sergey Senozhatsky
 <senozhatsky@...omium.org>, linux-kernel@...r.kernel.org,
 takakura@...inux.co.jp, youngmin.nam@...sung.com, hajun.sung@...sung.com,
 seungh.jung@...sung.com, jh1012.choi@...sung.com
Subject: Re: [PATCH] printk/panic: Add option allow non panic cpus logging
 to ringbuffer

On 2025-03-17, Petr Mladek <pmladek@...e.com> wrote:
>> +#ifdef CONFIG_PRINTK_CALLER
>> +static int __init printk_debug_non_panic_cpus_setup(char *str)
>> +{
>> +	printk_debug_non_panic_cpus = true;
>> +	pr_info("printk: keep printk all cpu in panic.\n");
>
> I would update the message:
>
> 	pr_info("printk: allow messages from non-panic CPUs in panic()\n");

Note that every printk message in printk.c is automatically prepended
with "printk: " (see #define pr_fmt(fmt) at the top of printk.c) so
please just use:

	pr_info("allow messages from non-panic CPUs in panic()\n");

John Ogness