linux-kernel - Re: [PATCH] btrfs: fix signedness issue in min()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317141637.5ee242ad@pumpkin>
Date: Mon, 17 Mar 2025 14:16:37 +0000
From: David Laight <david.laight.linux@...il.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, David
 Sterba <dsterba@...e.com>, Qu Wenruo <wqu@...e.com>, Arnd Bergmann
 <arnd@...db.de>, Johannes Thumshirn <johannes.thumshirn@....com>, Filipe
 Manana <fdmanana@...e.com>, Li Zetao <lizetao1@...wei.com>,
 linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 akpm@...ux-foundation.org
Subject: Re: [PATCH] btrfs: fix signedness issue in min()

On Fri, 14 Mar 2025 16:54:41 +0100
Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> Comparing a u64 to an loff_t causes a warning in min()
> 
> fs/btrfs/extent_io.c: In function 'extent_write_locked_range':
> include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_588' declared with attribute error: min(folio_pos(folio) + folio_size(folio) - 1, end) signedness error
> fs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
>  2472 |                 cur_end = min(folio_pos(folio) + folio_size(folio) - 1, end);
>       |                           ^~~
> 
> Use min_t() instead.

It would be slightly better to use min_unsigned() since, regardless of the types
involved, it can't discard significant bits.

OTOH the real problem here is that both folio_pos() and folio_size() return signed types.

	David

> 
> Fixes: f286b1c72175 ("btrfs: prepare extent_io.c for future larger folio support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  fs/btrfs/extent_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index c2451194be66..88bced0bfa51 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2468,7 +2468,7 @@ void extent_write_locked_range(struct inode *inode, const struct folio *locked_f
>  			continue;
>  		}
>  
> -		cur_end = min(folio_pos(folio) + folio_size(folio) - 1, end);
> +		cur_end = min_t(u64, folio_pos(folio) + folio_size(folio) - 1, end);
>  		cur_len = cur_end + 1 - cur;
>  
>  		ASSERT(folio_test_locked(folio));