linux-kernel - Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21de806b-1d25-4feb-bc30-1b5c3adf1bb0@kernel.org>
Date: Mon, 17 Mar 2025 15:55:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: John Madieu <john.madieu.xa@...renesas.com>
Cc: "geert+renesas@...der.be" <geert+renesas@...der.be>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "robh@...nel.org"
 <robh@...nel.org>, "rafael@...nel.org" <rafael@...nel.org>,
 "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
 "magnus.damm@...il.com" <magnus.damm@...il.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "john.madieu@...il.com" <john.madieu@...il.com>,
 "rui.zhang@...el.com" <rui.zhang@...el.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
 "sboyd@...nel.org" <sboyd@...nel.org>, Biju Das
 <biju.das.jz@...renesas.com>,
 "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
 "lukasz.luba@....com" <lukasz.luba@....com>
Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal

On 17/03/2025 12:14, John Madieu wrote:
> Hi Krzysztof,
> 
> Thanks for the review!
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: Monday, March 17, 2025 10:29 AM
>> To: John Madieu <john.madieu.xa@...renesas.com>
>> Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal
>>
>> On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote:
>>> Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC.
>>
>> s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your
>> platform defconfig, but all platforms and all users defconfig.
>>
> 
> Noted for the fix.
> 
> However, most thermal drivers use SOC-specific config options,
> as we can see in arm64 defconfig:
> 
> [...]
> CONFIG_IMX8MM_THERMAL=m
> CONFIG_K3_THERMAL=m
> CONFIG_QORIQ_THERMAL=m
> CONFIG_SUN8I_THERMAL=y
> CONFIG_ROCKCHIP_THERMAL=m
> CONFIG_RCAR_THERMAL=y
> CONFIG_RCAR_GEN3_THERMAL=y
> CONFIG_RZG2L_THERMAL=y
> CONFIG_ARMADA_THERMAL=y
> CONFIG_MTK_THERMAL=m
> CONFIG_MTK_LVTS_THERMAL=m
> CONFIG_BCM2711_THERMAL=m
> CONFIG_BCM2835_THERMAL=m
> CONFIG_BRCMSTB_THERMAL=m
> [...]
> 
> Hence my choice for RZG3E_THERMAL, or did I miss something in your comment?
Your commit msg must explain why do we want it. I gave you idea, if you
don't want to use it, sure, come with other.

Best regards,
Krzysztof