linux-kernel - Re: [PATCH v1 2/2] ARM: tegra: Add device-tree for ASUS Transformer Pad LTE TF300TL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dde3fd48-f5ac-4c82-aff3-8dae255d4cd2@kernel.org>
Date: Mon, 17 Mar 2025 16:03:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Thierry Reding <treding@...dia.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Maxim Schwalm <maxim.schwalm@...il.com>, Brad Griffis <bgriffis@...dia.com>,
 Dara Stotland <dstotland@...dia.com>, David Heidelberg <david@...t.cz>,
 Ion Agorria <ion@...rria.com>, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] ARM: tegra: Add device-tree for ASUS Transformer
 Pad LTE TF300TL

On 17/03/2025 12:19, Svyatoslav Ryhel wrote:
> пн, 17 бер. 2025 р. о 13:04 Krzysztof Kozlowski <krzk@...nel.org> пише:
>>
>> On Sat, Mar 15, 2025 at 09:44:16AM +0200, Svyatoslav Ryhel wrote:
>>> +#include "tegra30-asus-transformer-common.dtsi"
>>> +#include "tegra30-asus-lvds-display.dtsi"
>>> +
>>> +/ {
>>> +     model = "Asus Transformer Pad LTE TF300TL";
>>> +     compatible = "asus,tf300tl", "nvidia,tegra30";
>>> +
>>> +     gpio@...0d000 {
>>> +             tf300tl-init-hog {
>>> +                     gpio-hog;
>>> +                     gpios = <TEGRA_GPIO(C, 6) GPIO_ACTIVE_HIGH>;
>>> +                     output-low;
>>> +             };
>>> +     };
>>> +
>>> +     pinmux@...00868 {
>>> +             state_default: pinmux {
>>> +                     lcd_pwr2_pc6 {
>>
>> No underscores in node names.
>>
> 
> These bindings overwrite bindings in the common pinmux configuration
> which has names with underscores, so underscores are needed for
> correct configuration.

Ack, this Tegra coding style will make big even such trivial fixup...

Best regards,
Krzysztof