[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Z9eeeTpSr-vVD5eL@Mac.home>
Date: Sun, 16 Mar 2025 21:00:57 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Antonio Hickey <contact@...e-forge.io>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>,
Antonio Hickey <contact@...oniohickey.com>,
rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 04/16] rust: task: refactor to use `&raw [const|mut]`
Hi Antonio,
On Sun, Mar 16, 2025 at 02:14:13AM -0400, Antonio Hickey wrote:
> Replacing all occurrences of `addr_of!(place)` and `addr_of_mut!(place)`
> with `&raw const place` and `&raw mut place` respectively.
>
> This will allow us to reduce macro complexity, and improve consistency
> with existing reference syntax as `&raw const`, `&raw mut` are similar
> to `&`, `&mut` making it fit more naturally with other existing code.
>
> Suggested-by: Benno Lossin <benno.lossin@...ton.me>
> Link: https://github.com/Rust-for-Linux/linux/issues/1148
You need to change the above because this patch doesn't replace
addr_of_{,mut}!() with `&raw`, and also the patch title. Thanks!
Regards,
Boqun
> Signed-off-by: Antonio Hickey <contact@...oniohickey.com>
> ---
> rust/kernel/task.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/task.rs b/rust/kernel/task.rs
> index 49012e711942..568b528e2cc4 100644
> --- a/rust/kernel/task.rs
> +++ b/rust/kernel/task.rs
> @@ -257,7 +257,7 @@ pub fn as_ptr(&self) -> *mut bindings::task_struct {
> pub fn group_leader(&self) -> &Task {
> // SAFETY: The group leader of a task never changes after initialization, so reading this
> // field is not a data race.
> - let ptr = unsafe { *ptr::addr_of!((*self.as_ptr()).group_leader) };
> + let ptr = unsafe { (*self.as_ptr()).group_leader };
>
> // SAFETY: The lifetime of the returned task reference is tied to the lifetime of `self`,
> // and given that a task has a reference to its group leader, we know it must be valid for
> @@ -269,7 +269,7 @@ pub fn group_leader(&self) -> &Task {
> pub fn pid(&self) -> Pid {
> // SAFETY: The pid of a task never changes after initialization, so reading this field is
> // not a data race.
> - unsafe { *ptr::addr_of!((*self.as_ptr()).pid) }
> + unsafe { (*self.as_ptr()).pid }
> }
>
> /// Returns the UID of the given task.
> --
> 2.48.1
>
Powered by blists - more mailing lists