linux-kernel - Re: [PATCH 1/2] tcp: fix races in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9em2njRsaoKNBG0@perf>
Date: Mon, 17 Mar 2025 13:36:42 +0900
From: Youngmin Nam <youngmin.nam@...sung.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: stable@...r.kernel.org, ncardwell@...gle.com, edumazet@...gle.com,
	kuba@...nel.org, davem@...emloft.net, dsahern@...nel.org, pabeni@...hat.com,
	horms@...nel.org, guo88.liu@...sung.com, yiwang.cai@...sung.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	joonki.min@...sung.com, hajun.sung@...sung.com, d7271.choe@...sung.com,
	sw.ju@...sung.com, dujeong.lee@...sung.com, ycheng@...gle.com,
	yyd@...gle.com, kuro@...oa.me, cmllamas@...gle.com, willdeacon@...gle.com,
	maennich@...gle.com, gregkh@...gle.com, Lorenzo Colitti
	<lorenzo@...gle.com>, Jason Xing <kerneljasonxing@...il.com>, Youngmin Nam
	<youngmin.nam@...sung.com>
Subject: Re: [PATCH 1/2] tcp: fix races in tcp_abort()

On Fri, Mar 14, 2025 at 01:24:09PM +0100, Greg KH wrote:
> On Fri, Mar 14, 2025 at 06:24:45PM +0900, Youngmin Nam wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > tcp_abort() has the same issue than the one fixed in the prior patch
> > in tcp_write_err().
> > 
> > commit 5ce4645c23cf5f048eb8e9ce49e514bababdee85 upstream.
> > 
> > To apply commit bac76cf89816bff06c4ec2f3df97dc34e150a1c4,
> > this patch must be applied first.
> > 
> > In order to get consistent results from tcp_poll(), we must call
> > sk_error_report() after tcp_done().
> > 
> > We can use tcp_done_with_error() to centralize this logic.
> > 
> > Fixes: c1e64e298b8c ("net: diag: Support destroying TCP sockets.")
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Acked-by: Neal Cardwell <ncardwell@...gle.com>
> > Link: https://lore.kernel.org/r/20240528125253.1966136-4-edumazet@google.com
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > Cc: <stable@...r.kernel.org> # v5.10+
> 
> Did not apply to 5.10.y, what did you want this added to?
> 
> thanks,
> 
> greg k-h
> 

Hi Greg,

Sorry about that.

As for 5.10, it seems to have more dependencies for the backport.
I think the maintainer should handle it to ensure a safe backport.