linux-kernel - Re: [PATCH v4 3/4] dt-bindings: nand: Add fsl,elbc-fcm-nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174222739794.60508.9641557469920880307.robh@kernel.org>
Date: Mon, 17 Mar 2025 11:03:18 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: J. Neuschäfer <j.ne@...teo.net>
Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Nicholas Piggin <npiggin@...il.com>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Naveen N Rao <naveen@...nel.org>, Frank Li <Frank.Li@....com>,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Vignesh Raghavendra <vigneshr@...com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	devicetree@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Richard Weinberger <richard@....at>,
	Crystal Wood <oss@...error.net>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v4 3/4] dt-bindings: nand: Add fsl,elbc-fcm-nand


On Thu, 13 Mar 2025 22:35:46 +0100, J. Neuschäfer wrote:
> Formalize the binding already supported by the fsl_elbc_nand.c driver
> and used in several device trees in arch/powerpc/boot/dts/.
> 
> raw-nand-chip.yaml is referenced in order to accommodate situations in
> which the ECC parameters settings are set in the device tree. One such
> example is in arch/powerpc/boot/dts/turris1x.dts:
> 
> 	/* MT29F2G08ABAEAWP:E NAND */
> 	nand@1,0 {
> 		compatible = "fsl,p2020-fcm-nand", "fsl,elbc-fcm-nand";
> 		reg = <0x1 0x0 0x00040000>;
> 		nand-ecc-mode = "soft";
> 		nand-ecc-algo = "bch";
> 
> 		partitions { ... };
> 	};
> 
> Reviewed-by: Frank Li <Frank.Li@....com>
> Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> ---
> 
> V4:
> - no changes
> 
> V3:
> - remove unnecessary #address/size-cells from nand node in example
> - add Frank Li's review tag
> - add missing end of document marker (...)
> - explain choice to reference raw-nand-chip.yaml
> 
> V2:
> - split out from fsl,elbc binding patch
> - constrain #address-cells and #size-cells
> - add a general description
> - use unevaluatedProperties=false instead of additionalProperties=false
> - fix property order to comply with dts coding style
> - include raw-nand-chip.yaml instead of nand-chip.yaml
> ---
>  .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++++++++
>  1 file changed, 68 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>