[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fWqpcwc021enM8uMChSgCRB+UW_6z7+=pdsQG9msLJsbw@mail.gmail.com>
Date: Mon, 17 Mar 2025 09:10:29 -0700
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
Kan Liang <kan.liang@...ux.intel.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1 next] tools build: Remove the libunwind feature tests
from the ones detected when test-all.o builds
On Wed, Dec 11, 2024 at 7:45 AM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> We have a tools/build/feature/test-all.c that has the most common set of
> features that perf uses and are expected to have its development files
> available when building perf.
>
> When we made libwunwind opt-in we forgot to remove them from the list of
> features that are assumed to be available when test-all.c builds, remove
> them.
>
> Before this patch:
>
> $ rm -rf /tmp/b ; mkdir /tmp/b ; make -C tools/perf O=/tmp/b feature-dump ; grep feature-libunwind-aarch64= /tmp/b/FEATURE-DUMP
> feature-libunwind-aarch64=1
> $
>
> Even tho this not being test built and those header files being
> available:
>
> $ head -5 tools/build/feature/test-libunwind-aarch64.c
> // SPDX-License-Identifier: GPL-2.0
> #include <libunwind-aarch64.h>
> #include <stdlib.h>
>
> extern int UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as,
> $
>
> After this patch:
>
> $ grep feature-libunwind- /tmp/b/FEATURE-DUMP
> $
>
> Now an audit on what is being enabled when test-all.c builds will be
> performed.
>
> Fixes: 176c9d1e6a06f2fa ("tools features: Don't check for libunwind devel files by default")
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: James Clark <james.clark@...aro.org>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
Sorry for the delay on this.
Reviewed-by: Ian Rogers <irogers@...gle.com>
Thanks,
Ian
> ---
> tools/build/Makefile.feature | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index b2884bc23775e986..9cde51104c2d70ec 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -90,13 +90,6 @@ FEATURE_TESTS_EXTRA := \
> libbfd-liberty \
> libbfd-liberty-z \
> libopencsd \
> - libunwind-x86 \
> - libunwind-x86_64 \
> - libunwind-arm \
> - libunwind-aarch64 \
> - libunwind-debug-frame \
> - libunwind-debug-frame-arm \
> - libunwind-debug-frame-aarch64 \
> cxx \
> llvm \
> clang \
> --
> 2.47.0
>
Powered by blists - more mailing lists