linux-kernel - Re: [PATCH v3 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250317-cornflower-tortoise-of-stamina-7aa54b@houat>
Date: Mon, 17 Mar 2025 17:22:44 +0100
From: Maxime Ripard <mripard@...nel.org>
To: David Turner <david.turner@...pberrypi.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Dave Stevenson <dave.stevenson@...pberrypi.com>, 
	Maíra Canal <mcanal@...lia.com>, Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH v3 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on
 disconnect

On Mon, Mar 17, 2025 at 02:37:03PM +0000, David Turner wrote:
> Hi Maxime,
> 
> Thanks for the reviews.
> 
> On Fri, 14 Mar 2025 at 13:33, Maxime Ripard <mripard@...nel.org> wrote:
> > I also think that it's wrong, it's not just about audio. It just needs
> > to be called as part of detect no matter what the status is. Audio is
> > one thing that it will possibly handle depending on the driver, but
> > EDIDs, CEC, etc. might also be dealt with. So I don't think it's right
> > to focus on audio there.
> 
> Does this wording sound ok?
> 
>  * This function should be called as a part of the .detect() / .detect_ctx()
>  * callbacks for all status changes in order to update the HDMI-specific
>  * connector's data.

I'd drop everything after "in order to..." but yeah, it's much better, thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (274 bytes)