linux-kernel - Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22ffa8f5-6590-4602-853d-ceffed580f22@sirena.org.uk>
Date: Mon, 17 Mar 2025 16:45:31 +0000
From: Mark Brown <broonie@...ian.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Sowjanya Komatineni <skomatineni@...dia.com>,
	Laxman Dewangan <ldewangan@...dia.com>, linux-tegra@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	rmikey@...a.com, kernel-team@...a.com
Subject: Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional()
 instead of device_reset()

On Mon, Mar 17, 2025 at 08:44:01AM -0700, Breno Leitao wrote:
> My UEFI machines with tegra210-quad consistently report "device reset
> failed". Investigation showed this isn't an actual failure
> - __device_reset() returns -ENOENT because ACPI has no "*_RST" method.

That's not the case, it's returning an error because there is no reset
controller discoverable via any mechanism.  There's no specific handling
for ACPI here.  It's also not clear that this is a false positive, the
driver did indeed fail to reset the device and especially for the error
handling case that seems like relevant information.  At the very least
the changelog should be clarified.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)