[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-7-bd924634b889@linaro.org>
Date: Mon, 17 Mar 2025 00:39:39 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>
Cc: Jingjing Xiong <jingjing.xiong@...el.com>, Hao Yao <hao.yao@...el.com>,
Jim Lai <jim.lai@...el.com>, You-Sheng Yang <vicamo.yang@...onical.com>,
Alan Stern <stern@...land.harvard.edu>, Hans de Goede <hdegoede@...hat.com>,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Subject: [PATCH 7/8] media: i2c: ov02e10: Remove redundant dev_dbg() and
some extra dev_err()
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
---
drivers/media/i2c/ov02e10.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/media/i2c/ov02e10.c b/drivers/media/i2c/ov02e10.c
index 40c4d3ee36e3e2a0bb8be3ff10d016e2bb9bbc9d..2c15df8ca733aa4f37e125ac3bfb51a319e34c6e 100644
--- a/drivers/media/i2c/ov02e10.c
+++ b/drivers/media/i2c/ov02e10.c
@@ -316,7 +316,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl)
switch (ctrl->id) {
case V4L2_CID_ANALOGUE_GAIN:
- dev_dbg(&client->dev, "set analog gain\n");
cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG,
OV02E10_PAGE_1, &ret);
cci_write(ov02e10->regmap, OV02E10_REG_ANALOG_GAIN,
@@ -324,7 +323,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl)
break;
case V4L2_CID_DIGITAL_GAIN:
- dev_dbg(&client->dev, "set digital gain\n");
cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG,
OV02E10_PAGE_1, &ret);
cci_write(ov02e10->regmap, OV02E10_REG_DIGITAL_GAIN,
@@ -332,7 +330,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl)
break;
case V4L2_CID_EXPOSURE:
- dev_dbg(&client->dev, "set exposure\n");
cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG,
OV02E10_PAGE_1, &ret);
cci_write(ov02e10->regmap, OV02E10_REG_EXPOSURE,
@@ -340,7 +337,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl)
break;
case V4L2_CID_VBLANK:
- dev_dbg(&client->dev, "set vblank\n");
cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG,
OV02E10_PAGE_1, &ret);
cci_write(ov02e10->regmap, OV02E10_REG_VTS,
@@ -348,7 +344,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl)
break;
case V4L2_CID_TEST_PATTERN:
- dev_dbg(&client->dev, "set test pattern\n");
cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG,
OV02E10_PAGE_1, &ret);
ov02e10_test_pattern(ov02e10, ctrl->val, &ret);
@@ -358,7 +353,7 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl)
ret = -EINVAL;
break;
}
- dev_dbg(&client->dev, "will update cmd\n");
+
cci_write(ov02e10->regmap, OV02E10_REG_COMMAND_UPDATE,
OV02E10_COMMAND_UPDATE, &ret);
@@ -510,7 +505,6 @@ static int ov02e10_set_stream(struct v4l2_subdev *sd, int enable)
ret = ov02e10_start_streaming(ov02e10);
if (ret) {
- dev_dbg(&client->dev, "start streaming failed\n");
enable = 0;
ov02e10_stop_streaming(ov02e10);
pm_runtime_put(&client->dev);
@@ -903,7 +897,6 @@ static int ov02e10_probe(struct i2c_client *client)
/* Set default mode to max resolution */
ov02e->cur_mode = &supported_modes[0];
- dev_dbg(&client->dev, "will Init controls\n");
ret = ov02e10_init_controls(ov02e);
if (ret)
return ret;
@@ -917,10 +910,8 @@ static int ov02e10_probe(struct i2c_client *client)
/* Initialize source pad */
ov02e->pad.flags = MEDIA_PAD_FL_SOURCE;
ret = media_entity_pads_init(&ov02e->sd.entity, 1, &ov02e->pad);
- if (ret) {
- dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
+ if (ret)
goto error_handler_free;
- }
ret = v4l2_async_register_subdev_sensor(&ov02e->sd);
if (ret < 0) {
@@ -944,11 +935,10 @@ static int ov02e10_probe(struct i2c_client *client)
error_handler_free:
v4l2_ctrl_handler_free(ov02e->sd.ctrl_handler);
mutex_destroy(&ov02e->mutex);
- dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
+
error_power_off:
ov02e10_power_off(&client->dev);
- dev_dbg(&client->dev, "probe done\n");
return ret;
}
--
2.48.1
Powered by blists - more mailing lists