linux-kernel - Re: [net-next PATCH v2] octeontx2-af: fix build warnings flagged by clang, sparse ,kernel test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250317170154.GF688833@kernel.org>
Date: Mon, 17 Mar 2025 17:01:54 +0000
From: Simon Horman <horms@...nel.org>
To: Sai Krishna Gajula <saikrishnag@...vell.com>
Cc: "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Geethasowjanya Akula <gakula@...vell.com>,
	Linu Cherian <lcherian@...vell.com>,
	Jerin Jacob <jerinj@...vell.com>,
	Hariprasad Kelam <hkelam@...vell.com>,
	Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	Bharat Bhushan <bbhushan2@...vell.com>,
	"nathan@...nel.org" <nathan@...nel.org>,
	"ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
	"morbo@...gle.com" <morbo@...gle.com>,
	"justinstitt@...gle.com" <justinstitt@...gle.com>,
	"llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
	kernel test robot <lkp@...el.com>
Subject: Re: [net-next PATCH v2] octeontx2-af: fix build warnings flagged by
 clang, sparse ,kernel test robot

On Tue, Mar 11, 2025 at 08:57:22AM +0000, Sai Krishna Gajula wrote:

...

> > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > index cd0d7b7774f1..c850ea5d1960 100644
> > > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > @@ -591,7 +591,7 @@ static void rvu_check_min_msix_vec(struct rvu
> > > *rvu, int nvecs, int pf, int vf)
> > >
> > >  check_pf:
> > >  	if (pf == 0)
> > > -		min_vecs = RVU_AF_INT_VEC_CNT + RVU_PF_INT_VEC_CNT;
> > > +		min_vecs = (int)RVU_AF_INT_VEC_CNT +
> > (int)RVU_PF_INT_VEC_CNT;
> > >  	else
> > >  		min_vecs = RVU_PF_INT_VEC_CNT;
> > >
> > 
> > I think that in the light of Linus's feedback and the subsequent patch that
> > demoted -Wenum-enum-conversion from W=1 to W=1 this is not necessary.
> 
> Ack, will ignore these changes which are flagged by  -Wenum-enum-conversion

Thanks,

FTR this should have read "from W=1 to W=2"

...