[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250317051951.3065011-3-yschu@nuvoton.com>
Date: Mon, 17 Mar 2025 13:19:50 +0800
From: Stanley Chu <stanley.chuys@...il.com>
To: frank.li@....com,
miquel.raynal@...tlin.com,
alexandre.belloni@...tlin.com,
linux-i3c@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org,
tomer.maimon@...oton.com,
kwliu@...oton.com,
yschu@...oton.com
Subject: [PATCH v1 2/3] i3c: master: svc: Use readsb helper for reading MDB
From: Stanley Chu <yschu@...oton.com>
The target can send the MDB byte followed by additional data bytes.
The readl on MRDATAB reads one actual byte, but the readsl advances
the destination pointer by 4 bytes. This causes the subsequent payload
to be copied to wrong position in the destination buffer.
Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Signed-off-by: Stanley Chu <yschu@...oton.com>
---
drivers/i3c/master/svc-i3c-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index a72ba5a7edd4..57b9dec6b5a8 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -425,7 +425,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
slot->len < SVC_I3C_FIFO_SIZE) {
mdatactrl = readl(master->regs + SVC_I3C_MDATACTRL);
count = SVC_I3C_MDATACTRL_RXCOUNT(mdatactrl);
- readsl(master->regs + SVC_I3C_MRDATAB, buf, count);
+ readsb(master->regs + SVC_I3C_MRDATAB, buf, count);
slot->len += count;
buf += count;
}
--
2.34.1
Powered by blists - more mailing lists