linux-kernel - Re: [PATCH] cxl: fix FWCTL dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250317174252.GA10600@ziepe.ca>
Date: Mon, 17 Mar 2025 14:42:52 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Dave Jiang <dave.jiang@...el.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Li Ming <ming.li@...omail.com>, Arnd Bergmann <arnd@...db.de>,
	Robert Richter <rrichter@....com>,
	"Mike Rapoport (Microsoft)" <rppt@...nel.org>,
	Masahiro Yamada <masahiroy@...nel.org>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl: fix FWCTL dependency

On Mon, Mar 10, 2025 at 08:24:44AM -0700, Dave Jiang wrote:
> 
> 
> On 3/10/25 6:51 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > The 'FWCTL' subsystem is selected by CXL_FEATURES, which is a 'bool' symbol
> > with a dependency on CXL_PCI, but referenced by the cxl_core.ko.
> > When cxl_core is built-in, but the cxl_pci.ko driver is a loadable mdoule,
> > this results in a link failure:
> > 
> > ld.lld-21: error: undefined symbol: _fwctl_alloc_device
> >>>> referenced by features.c:695 (/home/arnd/arm-soc/drivers/cxl/core/features.c:695)
> > ld.lld-21: error: undefined symbol: fwctl_register
> >>>> referenced by features.c:699 (/home/arnd/arm-soc/drivers/cxl/core/features.c:699)
> > ld.lld-21: error: undefined symbol: fwctl_unregister
> >>>> referenced by features.c:676 (/home/arnd/arm-soc/drivers/cxl/core/features.c:676)
> > 
> > Move the 'select' into the symbol that controls the core module instead.
> > 
> > Fixes: a53a6004e7a5 ("cxl: Add FWCTL support to CXL")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Acked-by: Dave Jiang <dave.jiang@...el.com>
> 
> Thanks for the fix Arnd. Jason can you please append this fix to your latest branch? Thanks!

I folded it into the Fixes commit thanks

Jason