linux-kernel - Re: [PATCH v7 1/6] dt-bindings: iio: filter: Add lpf/hpf freq margins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317185535.7d00444d@jic23-huawei>
Date: Mon, 17 Mar 2025 18:55:35 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Sam Winchenbach <sam.winchenbach@...mepointer.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org,
 lars@...afoo.de, Michael.Hennerich@...log.com, antoniu.miclaus@...log.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 bpellegrino@...a.org, Sam Winchenbach <swinchenbach@...a.org>
Subject: Re: [PATCH v7 1/6] dt-bindings: iio: filter: Add lpf/hpf freq
 margins

On Mon, 17 Mar 2025 11:07:32 -0400
Sam Winchenbach <sam.winchenbach@...mepointer.org> wrote:

> On Sun, Mar 16, 2025 at 05:38:42PM +0100, Krzysztof Kozlowski wrote:
> > On Sun, Mar 16, 2025 at 09:50:03AM -0400, Sam Winchenbach wrote:  
> > > From: Sam Winchenbach <swinchenbach@...a.org>
> > > 
> > > Adds two properties to add a margin when automatically finding the
> > > corner frequencies.
> > > 
> > > Signed-off-by: Sam Winchenbach <swinchenbach@...a.org>
> > > ---
> > >  .../bindings/iio/filter/adi,admv8818.yaml     | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)  
> > 
> > I don't understand. You got my tag. No changelog here, no cover letter,
> > nothing explains what happened here and why the tag is being removed.
> >   
> 
> Apologies,
> 
> I am still quite new to this workflow, and it deviates significantly
> from my day-to-day work. I mentioned in the previous patch set that I
> would like to update my email address and change:
> "driver core: -> iio: core:"
> I wasn't aware more than that was needed. Sorry for any confusion
> this may have caused.
> 
> In the future what is the preferred way to handle a
> situation like this? I wasn't aware of the cover letter feature but
> that looks like a promising option.

Either add stuff below the --- above as that doesn't end up in the
eventual git log, or --cover-letter on your git-format-patch and
put useful things like that in there.

> 
> It looks like another option is to add commentary to each patch.
> 
> I am less certain about your tag being removed - I don't fully
> understand that. Is there a way to preserve that if changes are made
> after you sign-off?

Once a tag is given it is up to the patch author to add it to the
patches for future versions.  That should only be dropped if the
author thinks there are significant enough changes to warrant a fresh
review.  If you do drop a tag like that, then the change log
under --- on the particular patch should clearly state why.
> 
> Sorry again about the confusion this caused,
No problem, takes a while for everyone to get used to a different
process. There are extensive docs, but it is still easy to miss
things!

Jonathan

> -Sam
> 
> > Best regards,
> > Krzysztof
> >