linux-kernel - [PATCH] drm/bridge: sil-sii8620: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503171404563447jAdJlVvoFXDvBoj0sAx6@zte.com.cn>
Date: Mon, 17 Mar 2025 14:04:56 +0800 (CST)
From: <zhang.enpei@....com.cn>
To: <neil.armstrong@...aro.org>
Cc: <andrzej.hajda@...el.com>, <rfoss@...nel.org>,
        <laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
        <jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
        <mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
        <simona@...ll.ch>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] drm/bridge: sil-sii8620: Use dev_err_probe()

From: ZhangEnpei <zhang.enpei@....com.cn>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: ZhangEnpei <zhang.enpei@....com.cn>
---
 drivers/gpu/drm/bridge/sil-sii8620.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
index 28a2e1ee04b2..1d0ee9c8d5b2 100644
--- a/drivers/gpu/drm/bridge/sil-sii8620.c
+++ b/drivers/gpu/drm/bridge/sil-sii8620.c
@@ -2178,12 +2178,9 @@ static int sii8620_extcon_init(struct sii8620 *ctx)

 	edev = extcon_find_edev_by_node(muic);
 	of_node_put(muic);
-	if (IS_ERR(edev)) {
-		if (PTR_ERR(edev) == -EPROBE_DEFER)
-			return -EPROBE_DEFER;
-		dev_err(ctx->dev, "Invalid or missing extcon\n");
-		return PTR_ERR(edev);
-	}
+	if (IS_ERR(edev))
+		return dev_err_probe(ctx->dev, PTR_ERR(edev),
+				     "Invalid or missing extcon\n");

 	ctx->extcon = edev;
 	ctx->extcon_nb.notifier_call = sii8620_extcon_notifier;
-- 
2.25.1