[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250317061116.GC27019@lst.de>
Date: Mon, 17 Mar 2025 07:11:16 +0100
From: Christoph Hellwig <hch@....de>
To: John Garry <john.g.garry@...cle.com>
Cc: brauner@...nel.org, djwong@...nel.org, cem@...nel.org,
dchinner@...hat.com, hch@....de, linux-xfs@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
ojaswin@...ux.ibm.com, ritesh.list@...il.com,
martin.petersen@...cle.com, tytso@....edu,
linux-ext4@...r.kernel.org
Subject: Re: [PATCH v6 03/13] iomap: rework IOMAP atomic flags
> iomap->flags |= IOMAP_F_NEW;
>
> + if (flags & IOMAP_ATOMIC)
> + iomap->flags |= IOMAP_F_ATOMIC_BIO;
> +
Add a comment here that ext4 is always using hardware atomics?
> + if (flags & IOMAP_ATOMIC)
> + iomap_flags |= IOMAP_F_ATOMIC_BIO;
Same here (at least for now until it is changed later).
> + * IOMAP_F_ATOMIC_BIO indicates that (write) I/O needs to be issued as an
> + * atomic bio, i.e. set REQ_ATOMIC.
s/needs to/will be/ ?
Powered by blists - more mailing lists