linux-kernel - Re: [PATCH linux-next] genirq: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2cf45ed-95ac-482c-9710-06cacc0189f9@kernel.org>
Date: Mon, 17 Mar 2025 07:37:56 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: xie.ludan@....com.cn, tglx@...utronix.de
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] genirq: use sysfs_emit() instead of
 scnprintf().

On 17. 03. 25, 7:27, xie.ludan@....com.cn wrote:
> Date: Fri, 14 Mar 2025 12:05:36 +0800
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: XieLudan <xie.ludan@....com.cn>

I point you to study Documentation/process/submitting-patches.rst first.

In particular, I am missing versioning and versionlog.

I would also appreciate being CCed on next versions of patches I am 
reviewing.

> --- a/kernel/irq/irqdesc.c
> +++ b/kernel/irq/irqdesc.c
> @@ -257,11 +257,11 @@ static ssize_t per_cpu_count_show(struct kobject *kobj,
>   	for_each_possible_cpu(cpu) {
>   		unsigned int c = irq_desc_kstat_cpu(desc, cpu);
> 
> -		ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%u", p, c);
> +		ret += sysfs_emit(buf + ret, "%s%u", p, c);

Sadly, the more important concern I had remained.

regards,
-- 
js
suse labs