linux-kernel - [PATCH] xen/pciback: use sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317151648132Sj7qhbVfKcPYvqCievFUf@zte.com.cn>
Date: Mon, 17 Mar 2025 15:16:48 +0800 (CST)
From: <tang.dongxing@....com.cn>
To: <jgross@...e.com>
Cc: <sstabellini@...nel.org>, <oleksandr_tyshchenko@...m.com>,
        <jiqian.chen@....com>, <ray.huang@....com>,
        <jeff.johnson@....qualcomm.com>, <minhuadotchen@...il.com>,
        <tang.dongxing@....com.cn>, <xen-devel@...ts.xenproject.org>,
        <linux-kernel@...r.kernel.org>, <ye.xingchen@....com.cn>,
        <yang.guang5@....com.cn>, <yang.yang29@....com.cn>,
        <xu.xin16@....com.cn>
Subject: [PATCH] xen/pciback: use sysfs_emit_at() instead of scnprintf()

From: TangDongxing <tang.dongxing@....com.cn>

Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: TangDongxing <tang.dongxing@....com.cn>
---
 drivers/xen/xen-pciback/pci_stub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index b616b7768c3b..a0782a74ed34 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -1281,7 +1281,7 @@ static ssize_t slots_show(struct device_driver *drv, char *buf)
 		if (count >= PAGE_SIZE)
 			break;

-		count += scnprintf(buf + count, PAGE_SIZE - count,
+		count += sysfs_emit_at(buf, count,
 				   "%04x:%02x:%02x.%d\n",
 				   pci_dev_id->domain, pci_dev_id->bus,
 				   PCI_SLOT(pci_dev_id->devfn),
-- 
2.25.1