linux-kernel - Re: [PATCH] tools/nolibc: drop manual stack pointer alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250317071836.GA5114@1wt.eu>
Date: Mon, 17 Mar 2025 08:18:36 +0100
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/nolibc: drop manual stack pointer alignment

On Sun, Mar 16, 2025 at 08:46:07PM +0100, Thomas Weißschuh wrote:
> The stack pointer is already aligned by the kernel to a multiple of 16.
> See STACK_ROUND() in fs/binfmt_elf.c.
> 
> The manual realignment is unnecessary, drop it.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Looks good to me, thanks Thomas!
Acked-by: Willy Tarreau <w@....eu>
Willy