linux-kernel - Re: [PATCH] power: supply: max77693: Fix wrong conversion of charge input threshold value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34ebbf48-3b61-472e-9175-1200b7637202@kernel.org>
Date: Mon, 17 Mar 2025 08:37:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>, Sebastian Reichel <sre@...nel.org>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH] power: supply: max77693: Fix wrong conversion of charge
 input threshold value

On 16/03/2025 21:11, Artur Weber wrote:
> The charge input threshold voltage register on the MAX77693 PMIC accepts
> four values: 0x0 for 4.3v, 0x1 for 4.7v, 0x2 for 4.8v and 0x3 for 4.9v.
> Due to an oversight, the driver calculated the values for 4.7v and above
> starting from 0x0, rather than from 0x1 ([(4700000 - 4700000) / 100000]
> gives 0).
> 
> Add 1 to the calculation to ensure that 4.7v is converted to a register
> value of 0x1 and that the other two voltages are converted correctly as
> well.
> 
> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
> Signed-off-by: Artur Weber <aweber.kernel@...il.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof