linux-kernel - [PATCH] nvme: replace max(a, min(b, c)) by clamp(b, a, c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317153909901uOL4saBkASEN9kOmQXDoP@zte.com.cn>
Date: Mon, 17 Mar 2025 15:39:09 +0800 (CST)
From: <shao.mingyin@....com.cn>
To: <hch@....de>
Cc: <sagi@...mberg.me>, <kch@...dia.com>, <linux-nvme@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <yang.tao172@....com.cn>,
        <yang.yang29@....com.cn>, <xu.xin16@....com.cn>
Subject: [PATCH] nvme: replace max(a, min(b, c)) by clamp(b, a, c)

From: LiHaoran <li.haoran7@....com.cn>

This patch replaces max(a, min(b, c)) by clamp(b, a, c) in the nvme
driver. This improves the readability.

Signed-off-by: LiHaoran <li.haoran7@....com.cn>
Cc: ShaoMingyin <shao.mingyin@....com.cn>
---
 drivers/nvme/target/nvmet.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index fcf4f460dc9a..30804b0ca66e 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -819,7 +819,7 @@ static inline u8 nvmet_cc_iocqes(u32 cc)
 /* Convert a 32-bit number to a 16-bit 0's based number */
 static inline __le16 to0based(u32 a)
 {
-	return cpu_to_le16(max(1U, min(1U << 16, a)) - 1);
+	return cpu_to_le16(clamp(1U << 16, 1U, a) - 1);
 }

 static inline bool nvmet_ns_has_pi(struct nvmet_ns *ns)
-- 
2.25.1