linux-kernel - Re: [PATCH v2 27/31] serial: 8250: use serial_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6427801-11e9-481c-9931-f7c95a6fb559@kernel.org>
Date: Mon, 17 Mar 2025 08:42:54 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v2 27/31] serial: 8250: use serial_port_in/out() helpers

On 17. 03. 25, 8:25, Andy Shevchenko wrote:
> On Mon, Mar 17, 2025 at 08:00:42AM +0100, Jiri Slaby (SUSE) wrote:
>> There are serial_port_in/out() helpers to be used instead of direct
>> p->serial_in/out(). Use them in various 8250 drivers.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> # 8250_dw
> 
> We also discussed adding some comments. Would you like to send an additional
> patch or do you rely on me adding them?

Ah, I considered them irrelevant when not using serial_in(), but 
serial_port_in() et al.

Please send them, it's your (good) work anyway.

thanks,
-- 
js
suse labs