[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Z9fWMaX25c8GIaQK@gmail.com>
Date: Mon, 17 Mar 2025 08:58:41 +0100
From: Ingo Molnar <mingo@...nel.org>
To: dmukhin@...d.com
Cc: Jonathan Corbet <corbet@....net>, Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/early_printk: add MMIO-based UARTs
* Denis Mukhin via B4 Relay <devnull+dmukhin.ford.com@...nel.org> wrote:
> + if (!strncmp(s, "nocfg", 5))
> + baudrate = 0;
> + else {
> + baudrate = simple_strtoul(s, &e, 0);
> + if (baudrate == 0 || s == e)
> + baudrate = DEFAULT_BAUD;
> + }
In standard kernel coding style we always balance curly braces and
don't skip them in the single-statement case. Ie. the above should be:
if (!strncmp(s, "nocfg", 5)) {
baudrate = 0;
} else {
> + if (baudrate)
> + early_serial_hw_init(115200 / baudrate);
Hm, I think that division will go poorly if 'baudrate' ends up being 0
in the 'nocfg' case ... ;-)
Thanks,
Ingo
Powered by blists - more mailing lists