linux-kernel - Re: [PATCH] ACPICA: Replace deprecated strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5cf8522-8967-40f5-9f7c-525ff535875c@kernel.org>
Date: Mon, 17 Mar 2025 09:19:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: feng.wei8@....com.cn, robert.moore@...el.com
Cc: rafael.j.wysocki@...el.com, lenb@...nel.org, linux-acpi@...r.kernel.org,
 acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPICA: Replace deprecated strncpy() with strscpy()

On 17/03/2025 07:38, feng.wei8@....com.cn wrote:
> diff --git a/drivers/acpi/acpica/utnonansi.c b/drivers/acpi/acpica/utnonansi.c
> index ff0802ace19b..1da9b8246011 100644
> --- a/drivers/acpi/acpica/utnonansi.c
> +++ b/drivers/acpi/acpica/utnonansi.c
> @@ -168,8 +168,7 @@ void acpi_ut_safe_strncpy(char *dest, char *source, acpi_size dest_size)
>  {
>  	/* Always terminate destination string */
> 
> -	strncpy(dest, source, dest_size);
> -	dest[dest_size - 1] = 0;
> +	strscpy(dest, source, dest_size);

What is the point of this function now?

Can ZTE slow down and address the feedback first?

Best regards,
Krzysztof