lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0ba8601e-2271-49d4-bfb7-50f4ff13baf3@oracle.com>
Date: Mon, 17 Mar 2025 08:22:07 +0000
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: brauner@...nel.org, djwong@...nel.org, cem@...nel.org, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com,
        ritesh.list@...il.com, martin.petersen@...cle.com, tytso@....edu,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v6 02/13] iomap: comment on atomic write checks in
 iomap_dio_bio_iter()

On 17/03/2025 06:08, Christoph Hellwig wrote:
> On Thu, Mar 13, 2025 at 05:12:59PM +0000, John Garry wrote:
>>   		if (iter->flags & IOMAP_ATOMIC_HW) {
>> +			/*
>> +			* Ensure that the mapping covers the full write length,
>> +			* otherwise we will submit multiple BIOs, which is
>> +			* disallowed.
>> +			*/
> 
> "disallowed" doesn't really explain anything, why is it disallowed?
> 
> Maybe:
> 
> 			* Ensure that the mapping covers the full write length,
> 			* otherwise it can't be submitted as a single bio,
> 			* which is required to use hardware atomics.

ok, fine.

> 


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ