linux-kernel - Re: [PATCH v1] net: phy: broadcom: Correct BCM5221 PHY model detection failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9fhqbfoQGSm1Njx@mev-dev.igk.intel.com>
Date: Mon, 17 Mar 2025 09:47:37 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jim Liu <jim.t90615@...il.com>
Cc: JJLIU0@...oton.com, florian.fainelli@...adcom.com, andrew@...n.ch,
	hkallweit1@...il.com, kuba@...nel.org, linux@...linux.org.uk,
	edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] net: phy: broadcom: Correct BCM5221 PHY model
 detection failure

On Mon, Mar 17, 2025 at 11:50:05AM +0800, Jim Liu wrote:
> Use "BRCM_PHY_MODEL" can be applied to the entire 5221 family of PHYs.
> 
> Fixes: 3abbd0699b67 (net: phy: broadcom: add support for BCM5221 phy)
> Signed-off-by: Jim Liu <JJLIU0@...oton.com>
> ---
>  drivers/net/phy/broadcom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index 22edb7e4c1a1..3529289e9d13 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -859,7 +859,7 @@ static int brcm_fet_config_init(struct phy_device *phydev)
>  		return reg;
>  
>  	/* Unmask events we are interested in and mask interrupts globally. */
> -	if (phydev->phy_id == PHY_ID_BCM5221)
> +	if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM5221)
>  		reg = MII_BRCM_FET_IR_ENABLE |
>  		      MII_BRCM_FET_IR_MASK;
>  	else
> @@ -888,7 +888,7 @@ static int brcm_fet_config_init(struct phy_device *phydev)
>  		return err;
>  	}
>  
> -	if (phydev->phy_id != PHY_ID_BCM5221) {
> +	if (BRCM_PHY_MODEL(phydev) != PHY_ID_BCM5221) {
>  		/* Set the LED mode */
>  		reg = __phy_read(phydev, MII_BRCM_FET_SHDW_AUXMODE4);
>  		if (reg < 0) {
> @@ -1009,7 +1009,7 @@ static int brcm_fet_suspend(struct phy_device *phydev)
>  		return err;
>  	}
>  
> -	if (phydev->phy_id == PHY_ID_BCM5221)
> +	if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM5221)
>  		/* Force Low Power Mode with clock enabled */
>  		reg = BCM5221_SHDW_AM4_EN_CLK_LPM | BCM5221_SHDW_AM4_FORCE_LPM;
>  	else
> -- 
> 2.34.1

It will be nice to have wider explanation what it is fixing in commit
message. Is phydev->phy_id different than phydev->driver->phy_id? Looks
like masking isn't crucial as phydev->driver->phy_id is initialized by
PHY_ID_BCM5221 which is already masked.

Anyway, looks fine, thanks.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>