linux-kernel - Re: [PATCH] [v2] crypto: lib/Kconfig: hide library options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5d23903c-7d95-4f3f-975a-7f2fbd70e12e@app.fastmail.com>
Date: Mon, 17 Mar 2025 10:04:48 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Herbert Xu" <herbert@...dor.apana.org.au>,
 "David Howells" <dhowells@...hat.com>
Cc: "Arnd Bergmann" <arnd@...nel.org>,
 "'bbrezillon@...nel.org'" <bbrezillon@...nel.org>,
 "Arnaud Ebalard" <arno@...isbad.org>, "Srujana Challa" <schalla@...vell.com>,
 "David S . Miller" <davem@...emloft.net>,
 "Jarkko Sakkinen" <jarkko@...nel.org>, "Paul Moore" <paul@...l-moore.com>,
 "James Morris" <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>,
 "Justin M. Forbes" <jforbes@...oraproject.org>,
 "Jason A . Donenfeld" <Jason@...c4.com>, "Rosen Penev" <rosenp@...il.com>,
 "Ard Biesheuvel" <ardb@...nel.org>,
 "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
 linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
 keyrings@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH] [v2] crypto: lib/Kconfig: hide library options

On Mon, Mar 17, 2025, at 09:37, Herbert Xu wrote:
> On Mon, Mar 17, 2025 at 08:36:25AM +0000, David Howells wrote:
>> Arnd Bergmann <arnd@...nel.org> wrote:
>> 
>> > -	depends on CRYPTO_LIB_CHACHA20POLY1305 = y
>> > +	select CRYPTO_LIB_CHACHA20POLY1305
>> 
>> Doesn't that allow CRYPTO_LIB_CHACHA20POLY1305=m?
>
> Not unless BIG_KEYS is tristate or under a tristate.

Right, or if it selects something that has a dependency.

Before commit 17ec3e71ba79 ("crypto: lib/Kconfig - Hide arch
options from user"), CRYPTO_LIB_CHACHA20POLY1305 had a
dependency on CONFIG_CRYPTO, so with CRYPTO=m, the 'select CRYPTO_LIB_CHACHA20POLY1305' in BIG_KEYS would result in
CRYPTO_LIB_CHACHA20POLY1305=m.

     Arnd