linux-kernel - Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwGub9FVh0rTnaE3FkuGrc5qRQJQ+_25-Jo61=OtmxXNMA@mail.gmail.com>
Date: Mon, 17 Mar 2025 10:21:14 +0100
From: Antheas Kapenekakis <lkml@...heas.dev>
To: Hans de Goede <hdegoede@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
	Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>
Subject: Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro
 quirk

On Mon, 17 Mar 2025 at 10:15, Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> > The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel.
> > Add a quirk to correct the panel portrait orientation. In addition,
> > it comes with a red limited edition variant in the Chinese market,
> > so add that as well.
> >
> > Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>
> drm-misc maintainers, I'm dealing with a huge backlog of
> patch-review, bugs and other work.
>
> So I would appreciate it if one of you can merge patches 1-3
> into drm-misc.
>
> Regards,
>
> Hans
>
> > ---
> >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 1378690b7287..f08cdc81dd9a 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -467,6 +467,18 @@ static const struct dmi_system_id orientation_data[] = {
> >                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
> >               },
> >               .driver_data = (void *)&lcd1600x2560_leftside_up,
> > +     }, {    /* OneXPlayer OneXFly F1 Pro (OLED) */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1Pro"),
> > +             },
> > +             .driver_data = (void *)&lcd1080x1920_leftside_up,
> > +     }, {    /* OneXPlayer OneXFly F1 Pro (OLED) LE Red variant */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> > +             },
> > +             .driver_data = (void *)&lcd1080x1920_leftside_up,
> >       }, {    /* OrangePi Neo */
> >               .matches = {
> >                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
>

Hi Hans,
patch 5 is also a panel quirk. Can you review that real quick as well
so it is not dangling?

Thanks,
Antheas