linux-kernel - Re: [PATCH v6 12/13] xfs: commit CoW-based atomic writes atomically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99d18591-39b7-4b2a-9f8c-7ebcbe4e286e@oracle.com>
Date: Mon, 17 Mar 2025 09:43:33 +0000
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: brauner@...nel.org, djwong@...nel.org, cem@...nel.org, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com,
        ritesh.list@...il.com, martin.petersen@...cle.com, tytso@....edu,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v6 12/13] xfs: commit CoW-based atomic writes atomically

On 17/03/2025 06:56, Christoph Hellwig wrote:
>>   		trace_xfs_reflink_end_cow_error(ip, error,_RET_IP_);
>>   	return error;
>>   }
>> +int
> Still a missing empty line after the previous function. 


Will fix.

>  Also
> please add a comment what is atomic about this function and why
> the regular path doesn't use it.

ok, fine