linux-kernel - Re: [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73631B5F-0916-4F81-AAB4-C8E2F4B999EC@mainlining.org>
Date: Mon, 17 Mar 2025 10:48:47 +0100
From: Barnabás Czémán <barnabas.czeman@...nlining.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Stephan Gerhold <stephan@...hold.net>,
 Otto Pflüger <otto.pflueger@...cue.de>,
 Linus Walleij <linus.walleij@...aro.org>, Lee Jones <lee@...nel.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Konrad Dybcio <konradybcio@...nel.org>,
 Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Dmitry Baryshkov <lumag@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 iommu@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, phone-devel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, linux@...nlining.org,
 Adam Skladowski <a39.skl@...il.com>
Subject: Re: [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510



On March 17, 2025 10:21:50 AM GMT+01:00, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote:
>> From: Adam Skladowski <a39.skl@...il.com>
>> 
>> Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976)
>> require Always-on branch clock to be enabled, describe it.
>> 
>> Signed-off-by: Adam Skladowski <a39.skl@...il.com>
>> [reword commit, move alwayson on the first place]
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> ---
>>  Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
>> index 6ddc72fd85b04537ea270754a897b4e7eb269641..5028398cc3b517e404a92a2c30688f72eab4c1b3 100644
>> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
>> @@ -152,11 +152,13 @@ allOf:
>>        properties:
>>          clocks:
>>            minItems: 2
>> -          maxItems: 7
>> +          maxItems: 8
>>  
>>          clock-names:
>>            items:
>>              anyOf:
>> +              - const: alwayson
>> +                description: GPU Always-On clock
>
>Are you adding bindings for devices which were not described previously?
>Then don't grow this pattern, but create if:then: with a strictly
>ordered list for them (and keeping order of other variants).
>
8956, 8976, 8953 schemas are failing because of missing always-on clock.
>Best regards,
>Krzysztof
>